Fix HTTP login and logout features #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numinnex
requested changes
Sep 6, 2024
| @@ -3,5 +3,5 @@ namespace Iggy_SDK.Contracts.Http; | |||
| public sealed class AuthResponse | |||
| { | |||
| public required int UserId { get; init; } | |||
| public Tokens? Tokens { get; init; } | |||
| public required TokenInfo? AccessToken { get; init; } | |||
There was a problem hiding this comment.
No point in making required a property that is nullable aswell.
There was a problem hiding this comment.
The fix is done.
I ended up changing the sealed class to record, since the usage of this data structure is only to be a data container, though.
jr-araujo
changed the title
numinnex
approved these changes
Sep 7, 2024
numinnex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the massive changes in the Iggyrs core, this PR is to fix 2 HTTP features:
Some other changes are in place: